-
Notifications
You must be signed in to change notification settings - Fork 122
Plugin/TagFix_Maxspeed_AT #2506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Your comments suggest code changes have been made but I don't see them here yet, possibly you forgot to push them live? |
I comment as I fix the problems, but push after final testing. Should be ready later today. Thanks for the detailed review. |
Removed failing test case (supposed to test for out-of-country data)
Reworded detail text as per osmose-qa#2506 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to run the plugin on a part of Austria but it seems the extracts server is down at the moment
Changed to commonly understood abbreviations
Co-authored-by: Famlam <[email protected]>
Removed failing test case (supposed to test for out-of-country data)
Reworded detail text as per osmose-qa#2506 (comment)
f603bc7
to
72795e3
Compare
After a lengthy session with ChatGPT, it turned out there were two problems on my side. First, I had push right for upstream, which I have now blocked locally (not that I intentionally used it). Second, though git reported my fork to be in sync, it wasn't and still had the old version of osmose_config.py. I have fixed that and can see the latest version everywhere. Hope that helps. |
I have tested with three provinces (including Niederösterreich, which has > 500.000 segments). Most errors come from either |
Some false positives:
Probably it's best to disable 303220 if there's other (Also, it may be better to replace |
This isn't a false positive. It should read Same for number 2. But these are extreme cases not worth dealing with at the moment. As mentioned, I've run this with 500K segments - and checked the error log. I can change the message if that's what it takes. Edit: for 2., it's |
Ok, I'd personally prefer to avoid requiring unnecessary tagging (if a single tag can indicate one looked to the front and to the back, why tag it twice... but hopefully those people will then use I'll leave it to the others to decide then :) |
It's not double tagging. One direction is usually the default, say `AT:rural`. The other one is `sign`. It would be a rare case to have signs in both directions, but even then explicit tagging is clean. Let's see how it works out, and it's easy to fix.
Edit: Let's not stress too much about the details, as this is limited to Austria. I'm present on the local community forum and will deal with any issues that may arise. I'm happy to translate the messages to German, just let me know when ready.
|
The plugin contains a number of tests focusing on
maxspeed
,maxspeed:type
andsource:maxspeed
specific to Austria. It is by no means complete, but will do until further community decisions have been taken.I've tested the logic locally, but have no Osmose dev environment. I need ids for 6 issue classes (currently numbered 1 to 6) and integration support. Test cases are provided, but have never run (I used a local test harness to feed data). I'd like to provide a German translation following successful integration.
#2503